linux-kernel - Re: [PATCH v5 03/24] ARM: tegra: Add labels to tegra30.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a684edd-aaa4-f96e-a72b-bb6d388e6b30@gmail.com>
Date:   Fri, 10 Dec 2021 19:26:16 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        David Heidelberg <david@...t.cz>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Anton Bambura <jenneron@...tonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljevic <mnidza@...look.com>,
        Ion Agorria <ion@...rria.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Ihor Didenko <tailormoon@...bler.ru>,
        Andreas Westman Dorcsak <hedmoo@...oo.com>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Raffaele Tranquillini <raffaele.tranquillini@...il.com>,
        Jasper Korten <jja2000@...il.com>,
        Thomas Graichen <thomas.graichen@...il.com>,
        Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 03/24] ARM: tegra: Add labels to tegra30.dtsi

10.12.2021 18:22, Thierry Reding пишет:
> On Wed, Dec 08, 2021 at 08:35:48PM +0300, Dmitry Osipenko wrote:
>> From: Michał Mirosław <mirq-linux@...e.qmqm.pl>
>>
>> Add phandle names for memory/I2C/SPI/USB/SDMMC controller nodes to allow
>> for cleaner device descriptions.
>>
>> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
>> ---
>>  arch/arm/boot/dts/tegra30.dtsi | 36 +++++++++++++++++-----------------
>>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> We typically only add those when they are really needed. These are
> technically harmless because without a reference, DTC won't actually
> create a phandle property, but dangling labels are the kind of thing
> that some janitor may at some point want to remove with some scripts,
> so I'm hesitant to apply this because it'll likely cause churn in the
> future.

The plan is to add labels for T20 and switch all DTs to use those
phandles consistently, but that's the plan for the next kernel release.

Those labels are practically useful when you porting something from old
downstream kernel because it uses those human-readable names instead of
the addresses.