linux-kernel - Re: [RFC PATCH] trace: Account bottom half disabled sections.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211210125155.27e910f4@gandalf.local.home>
Date:   Fri, 10 Dec 2021 12:51:55 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH] trace: Account bottom half disabled sections.

On Fri, 10 Dec 2021 16:37:06 +0100
Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote:

> Disabling only bottom halves via local_bh_disable() disables also
> preemption but this remains invisible to tracing. On a CONFIG_PREEMPT
> kernel one might wonder why there is no scheduling happening despite the
> N flag in the trace. The reason might be a rcu_read_lock_bh() section.
> 
> Add a 'b' to the tracing output if in task context with disabled bottom
> halves.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
>

Looks good to me. Care to resend without the RFC attached, and that will
make sure it gets into my scripts.

Thanks!

-- Steve