linux-kernel - Re: [Linux-cachefs] [RFC 09/19] netfs: refactor netfs_rreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a95618c5-723d-bfaa-bf7a-48950be8d31d@linux.alibaba.com>
Date:   Sat, 11 Dec 2021 13:44:47 +0800
From:   JeffleXu <jefflexu@...ux.alibaba.com>
To:     David Howells <dhowells@...hat.com>
Cc:     chao@...nel.org, tao.peng@...ux.alibaba.com,
        linux-kernel@...r.kernel.org, joseph.qi@...ux.alibaba.com,
        linux-cachefs@...hat.com, bo.liu@...ux.alibaba.com,
        linux-fsdevel@...r.kernel.org, xiang@...nel.org,
        gerry@...ux.alibaba.com, linux-erofs@...ts.ozlabs.org,
        eguan@...ux.alibaba.com
Subject: Re: [Linux-cachefs] [RFC 09/19] netfs: refactor netfs_rreq_unlock()



On 12/11/21 1:23 PM, JeffleXu wrote:
> 
> 
> On 12/10/21 11:41 PM, David Howells wrote:
>> Jeffle Xu <jefflexu@...ux.alibaba.com> wrote:
>>
>>> In demand-read case, the input folio of netfs API is may not the page
>>
>> "is may not the page"?  I think you're missing a verb (and you have too many
>> auxiliary verbs;-)
>>
> 
> Sorry for my poor English... What I want to express is that
> 
> "In demand-read case, the input folio of netfs API may not be the page
> cache inside the address space of the netfs file."
> 

By the way, can we change the current address_space based netfs API to
folio-based, which shall be more general? That is, the current
implementation of netfs API uses (address_space, page_offset, len) tuple
to describe the destination where the read data shall be store into.
While in the demand-read case, the input folio may not be the page
cache, and thus there's no address_space attached with it.

-- 
Thanks,
Jeffle