linux-kernel - Re: [PATCH v4 0/9] STM32 CRYP driver: many fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Dec 2021 16:55:45 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Nicolas Toromanoff <nicolas.toromanoff@...s.st.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Marek Vasut <marex@...x.de>, Ard Biesheuvel <ardb@...nel.org>,
        linux-crypto@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/9] STM32 CRYP driver: many fixes

On Tue, Nov 30, 2021 at 08:54:52AM +0100, Nicolas Toromanoff wrote:
> Hello,
> 
> This set of patches update the STM32 CRYP driver.
> 
> First two update about EPROBE_DEFER management.
> Then many fixes to success the cryptomanager EXTRA_TESTS.
> And finally we reorder the initialization to set the key as last step.
> 
> This patch series applies to cryptodev/master.
> 
> v1 -> v2 :
>   - use crypto_inc() in "crypto: stm32/cryp - fix CTR counter carry".
>   - more explicit commit description.
>   - with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y all tests pass, at boot
>     if built into kernel, at insmod if in module. (as v1)
> 
> v2->v3:
>   - fix smatch warning (that was a bug) in "crypto: stm32/cryp - fix bugs
>     and crash in tests" add missing parenthesis in mask/shift operation in
>     stm32_cryp_write_ccm_first_header(), was only visible in case of aad
>     buffer bigger than 65280 bytes.
>   - add a new commit to fix lrw chaining mode
> 
> v3->v4
>   - Fix sparse warning
>   - Rebase on cryptodev-2.6/master
>   - rework 0004-patch: with v1 correction, the xts extra tests using
>     stm32-cryp were still broken.
> 
> Etienne Carriere (2):
>   crypto: stm32/cryp - defer probe for reset controller
>   crypto: stm32/cryp - don't print error on probe deferral
> 
> Nicolas Toromanoff (7):
>   crypto: stm32/cryp - fix CTR counter carry
>   crypto: stm32/cryp - fix xts and race condition in crypto_engine
>     requests
>   crypto: stm32/cryp - check early input data
>   crypto: stm32/cryp - fix double pm exit
>   crypto: stm32/cryp - fix lrw chaining mode
>   crypto: stm32/cryp - fix bugs and crash in tests
>   crypto: stm32/cryp - reorder hw initialization
> 
>  drivers/crypto/stm32/stm32-cryp.c | 987 ++++++++++++------------------
>  1 file changed, 404 insertions(+), 583 deletions(-)
> 
> 
> base-commit: 330507fbc9d8c3bc4525ea2ae9c3774738bc0c80
> -- 
> 2.17.1

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt