linux-kernel - Re: [PATCH 08/25] x86/sgx: Make SGX IPI callback available internally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f04bc4ba7ed1d8a1dc62b89d4fc0de6e794126f2.camel@kernel.org>
Date:   Sat, 11 Dec 2021 09:53:17 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Reinette Chatre <reinette.chatre@...el.com>
Cc:     dave.hansen@...ux.intel.com, tglx@...utronix.de, bp@...en8.de,
        luto@...nel.org, mingo@...hat.com, linux-sgx@...r.kernel.org,
        x86@...nel.org, seanjc@...gle.com, kai.huang@...el.com,
        cathy.zhang@...el.com, cedric.xing@...el.com,
        haitao.huang@...el.com, mark.shanahan@...el.com, hpa@...or.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/25] x86/sgx: Make SGX IPI callback available
 internally

On Mon, 2021-12-06 at 13:36 -0800, Reinette Chatre wrote:
> Hi Jarkko,
> 
> On 12/4/2021 3:00 PM, Jarkko Sakkinen wrote:
> > On Wed, Dec 01, 2021 at 11:23:06AM -0800, Reinette Chatre wrote:
> > > The ETRACK instruction followed by an IPI to all CPUs within an enclave
> > > is a common pattern with more frequent use in support of SGX2.
> > > 
> > > Make the (empty) IPI callback function available internally in
> > > preparation for more usages.
> > 
> > Please, just describe the usages that this is needed for so that
> > there is zero guesswork required.
> 
> The reader is not required to guess. The first paragraph states that 
> SGX2 also uses the ETRACK flow that relies on this function. What if I 
> replace "for more usages" by "for usage by SGX2"?

I think that'd be good enough.

/Jarkko