linux-kernel - Re: [PATCH 1/6] dt-bindings: interrupt-controller: apple,aic: Add apple,aic2 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3cb417c9128faf1@bloch.sibelius.xs4all.nl>
Date:   Sat, 11 Dec 2021 13:49:14 +0100 (CET)
From:   Mark Kettenis <mark.kettenis@...all.nl>
To:     Hector Martin <marcan@...can.st>
Cc:     robh@...nel.org, tglx@...utronix.de, maz@...nel.org,
        sven@...npeter.dev, alyssa@...enzweig.io,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: interrupt-controller: apple,aic: Add
 apple,aic2 support

> From: Hector Martin <marcan@...can.st>
> Date: Sat, 11 Dec 2021 21:28:10 +0900
> 
> On 10/12/2021 02.28, Rob Herring wrote:
> > On Thu, Dec 09, 2021 at 01:32:44PM +0900, Hector Martin wrote:
> <snip>
> >> +  - if:
> >> +      properties:
> >> +        compatible:
> >> +          contains:
> >> +            enum:
> >> +              - apple,aic2
> >> +    then:
> >> +      required:
> >> +        - apple,event-reg
> > 
> > Is this property valid for aic1? If not, you need:
> > 
> > else:
> >    not:
> >      required:
> >        - apple,event-reg
> > 
> 
> Thanks, I wasn't sure how to do this. Took me a second to realize how 
> the logic works here, heh.
> 
> > 
> > I tend to think you should just make this a separate document. There's
> > not a whole lot of sharing (compared to any other interrupt controller).
> 
> Good point. I just kind of defaulted to this way because the driver is 
> the same (and does share a bunch), but indeed the binding doesn't really 
> reflect any of that. I'll split it off into another document for v2. 
> Might as well make the 4-argument interrupt form mandatory then (we use 
> it for all DTs, even the current 1-die machines, on AICv2 SoCs; the 
> driver can handle both but we might as well be stricter with the binding).

Simpler that way, so I'd support that.