linux-kernel - [hare-scsi-devel:ata-trace.v4 26/68] drivers/ata/pata_octeon_cf.c:602:30: error: passing argument 1 of 'trace_ata_bmdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 12 Dec 2021 00:13:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [hare-scsi-devel:ata-trace.v4 26/68]
 drivers/ata/pata_octeon_cf.c:602:30: error: passing argument 1 of
 'trace_ata_bmdma_stop' from incompatible pointer type

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git ata-trace.v4
head:   543d0f43ed9c7b04ab463b52f2e59fd406b4bde8
commit: 8ed76dafadec5839199e8defee70cb3f92502818 [26/68] pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one
config: mips-cavium_octeon_defconfig (https://download.01.org/0day-ci/archive/20211212/202112120054.E4wkKfKu-lkp@intel.com/config)
compiler: mips64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=8ed76dafadec5839199e8defee70cb3f92502818
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel ata-trace.v4
        git checkout 8ed76dafadec5839199e8defee70cb3f92502818
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/ata/pata_octeon_cf.c: In function 'octeon_cf_dma_finished':
>> drivers/ata/pata_octeon_cf.c:602:30: error: passing argument 1 of 'trace_ata_bmdma_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
     602 |         trace_ata_bmdma_stop(qc, &qc->tf, qc->tag);
         |                              ^~
         |                              |
         |                              struct ata_queued_cmd *
   In file included from include/trace/events/libata.h:10,
                    from drivers/ata/pata_octeon_cf.c:22:
   include/trace/events/libata.h:414:40: note: expected 'struct ata_port *' but argument is of type 'struct ata_queued_cmd *'
     414 |              TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),
         |                       ~~~~~~~~~~~~~~~~~^~
   include/linux/tracepoint.h:342:41: note: in definition of macro '__DECLARE_TRACE'
     342 |         static inline void trace_##name(proto)                          \
         |                                         ^~~~~
   include/linux/tracepoint.h:419:31: note: in expansion of macro 'PARAMS'
     419 |         __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
         |                               ^~~~~~
   include/linux/tracepoint.h:542:9: note: in expansion of macro 'DECLARE_TRACE'
     542 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
         |         ^~~~~~~~~~~~~
   include/linux/tracepoint.h:542:29: note: in expansion of macro 'PARAMS'
     542 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
         |                             ^~~~~~
   include/trace/events/libata.h:413:1: note: in expansion of macro 'DEFINE_EVENT'
     413 | DEFINE_EVENT(ata_exec_command_template, ata_bmdma_stop,
         | ^~~~~~~~~~~~
   include/trace/events/libata.h:414:14: note: in expansion of macro 'TP_PROTO'
     414 |              TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),
         |              ^~~~~~~~
   cc1: some warnings being treated as errors


vim +/trace_ata_bmdma_stop +602 drivers/ata/pata_octeon_cf.c

   586	
   587	/**
   588	 *
   589	 *	LOCKING:
   590	 *	spin_lock_irqsave(host lock)
   591	 *
   592	 */
   593	static unsigned int octeon_cf_dma_finished(struct ata_port *ap,
   594						struct ata_queued_cmd *qc)
   595	{
   596		struct ata_eh_info *ehi = &ap->link.eh_info;
   597		struct octeon_cf_port *cf_port = ap->private_data;
   598		union cvmx_mio_boot_dma_cfgx dma_cfg;
   599		union cvmx_mio_boot_dma_intx dma_int;
   600		u8 status;
   601	
 > 602		trace_ata_bmdma_stop(qc, &qc->tf, qc->tag);
   603	
   604		if (ap->hsm_task_state != HSM_ST_LAST)
   605			return 0;
   606	
   607		dma_cfg.u64 = cvmx_read_csr(cf_port->dma_base + DMA_CFG);
   608		if (dma_cfg.s.size != 0xfffff) {
   609			/* Error, the transfer was not complete.  */
   610			qc->err_mask |= AC_ERR_HOST_BUS;
   611			ap->hsm_task_state = HSM_ST_ERR;
   612		}
   613	
   614		/* Stop and clear the dma engine.  */
   615		dma_cfg.u64 = 0;
   616		dma_cfg.s.size = -1;
   617		cvmx_write_csr(cf_port->dma_base + DMA_CFG, dma_cfg.u64);
   618	
   619		/* Disable the interrupt.  */
   620		dma_int.u64 = 0;
   621		cvmx_write_csr(cf_port->dma_base + DMA_INT_EN, dma_int.u64);
   622	
   623		/* Clear the DMA complete status */
   624		dma_int.s.done = 1;
   625		cvmx_write_csr(cf_port->dma_base + DMA_INT, dma_int.u64);
   626	
   627		status = ap->ops->sff_check_status(ap);
   628	
   629		ata_sff_hsm_move(ap, qc, status, 0);
   630	
   631		if (unlikely(qc->err_mask) && (qc->tf.protocol == ATA_PROT_DMA))
   632			ata_ehi_push_desc(ehi, "DMA stat 0x%x", status);
   633	
   634		return 1;
   635	}
   636	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org