linux-kernel - [PATCH] pcmcia: pcmcia_resource: return 0 if success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Dec 2021 15:56:30 +0800
From:   Jason Wang <wangborong@...rlc.com>
To:     linux@...inikbrodowski.net
Cc:     lee.jones@...aro.org, wangborong@...rlc.com,
        linux-kernel@...r.kernel.org
Subject: [PATCH] pcmcia: pcmcia_resource: return 0 if success

The initial value of variable `ret' is -EINVAL, which is used for
returning the error status in `pcmcia_release_io' when errors occur.
But if there is no error in `pcmcia_release_io', `ret' should be changed
to a successful value to return. Thus we change `ret' value to 0 when
the function's status is successful.

Signed-off-by: Jason Wang <wangborong@...rlc.com>
---
 drivers/pcmcia/pcmcia_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index c1c197292111..257181cb686f 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -409,6 +409,7 @@ static int pcmcia_release_io(struct pcmcia_device *p_dev)
 
 	p_dev->_io = 0;
 	c->state &= ~CONFIG_IO_REQ;
+	ret = 0;
 
 out:
 	mutex_unlock(&s->ops_mutex);
-- 
2.34.1