linux-kernel - Re: [PATCH] EDAC/amd64: fix typo in a comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 12 Dec 2021 12:48:19 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Jason Wang <wangborong@...rlc.com>
Cc:     yazen.ghannam@....com, mchehab@...nel.org, tony.luck@...el.com,
        james.morse@....com, rric@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd64: fix typo in a comment

On Sun, Dec 12, 2021 at 11:26:53AM +0800, Jason Wang wrote:
> The double `reads' in the comment in line 126 is repeated. Remove one
> of them from the comment.
> 
> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>  drivers/edac/amd64_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

If you're going to waste your time fixing comments, then please fix your
commit message like I did for your previous patch:

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=b011a57e41ccbd402ecdcb53514ba76b898ec22e

And then I'd strongly suggest you try fixing real bugs - there's no
shortage of those - instead of wasting your and others' time with
comments fixes. Those can be addressed when someone is changing the code
in that area too.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette