linux-kernel - Re: [PATCHv2] selftests: icmp_redirect: pass xfail=0 to log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163931400832.17396.4075834071106906036.git-patchwork-notify@kernel.org>
Date:   Sun, 12 Dec 2021 13:00:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Po-Hsu Lin <po-hsu.lin@...onical.com>
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        skhan@...uxfoundation.org, andrea.righi@...onical.com,
        dsahern@...nel.org
Subject: Re: [PATCHv2] selftests: icmp_redirect: pass xfail=0 to log_test()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Fri, 10 Dec 2021 15:25:23 +0800 you wrote:
> If any sub-test in this icmp_redirect.sh is failing but not expected
> to fail. The script will complain:
>     ./icmp_redirect.sh: line 72: [: 1: unary operator expected
> 
> This is because when the sub-test is not expected to fail, we won't
> pass any value for the xfail local variable in log_test() and thus
> it's empty. Fix this by passing 0 as the 4th variable to log_test()
> for non-xfail cases.
> 
> [...]

Here is the summary with links:
  - [PATCHv2] selftests: icmp_redirect: pass xfail=0 to log_test()
    https://git.kernel.org/netdev/net/c/3748939bce3f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html