linux-kernel - Re: [PATCH 4/6] irqchip/apple-aic: Dynamically compute register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Dec 2021 18:26:58 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Hector Martin <marcan@...can.st>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 4/6] irqchip/apple-aic: Dynamically compute register offsets

On Thu, 09 Dec 2021 04:32:47 +0000,
Hector Martin <marcan@...can.st> wrote:
> 
> This allows us to support AIC variants with different numbers of IRQs
> based on capability registers.
> 
> Signed-off-by: Hector Martin <marcan@...can.st>
> ---
>  drivers/irqchip/irq-apple-aic.c | 73 +++++++++++++++++++++++++--------
>  1 file changed, 56 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 572d1af175fc..d03caed51d56 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -312,12 +326,15 @@ static int aic_irq_set_affinity(struct irq_data *d,
>  	struct aic_irq_chip *ic = irq_data_get_irq_chip_data(d);
>  	int cpu;
>  
> +	if (!ic->info.target_cpu)
> +		return -EINVAL;

Can this even happen? And if it did, this should scream loudly,
shouldn't it?

	M.

-- 
Without deviation from the norm, progress is not possible.