linux-kernel - RE: [PATCH] i2c: exynos5: Fix getting the optional clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Dec 2021 09:00:48 +0900
From:   "Chanho Park" <chanho61.park@...sung.com>
To:     "'Sam Protsenko'" <semen.protsenko@...aro.org>,
        "'Wolfram Sang'" <wsa@...nel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...onical.com>
Cc:     "'Jaewon Kim'" <jaewon02.kim@...sung.com>,
        <linux-i2c@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] i2c: exynos5: Fix getting the optional clock

> "hsi2c_pclk" clock is optional and may not be present for some SoCs
> supported by this driver. Nevertheless, in case the clock is provided but
> some error happens during its getting, that error should be handled
> properly. Use devm_clk_get_optional() API for that. Also report possible
> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
> clock provider is not ready by the time I2C probe function is executed).
> 
> Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support")
> Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>

Reviewed-by: Chanho Park <chanho61.park@...sung.com>