linux-kernel - Re: [PATCH] drm: simpledrm: fix wrong unit with pixel clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Dec 2021 11:30:03 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Alejandro Concepcion-Rodriguez <asconcepcion@...ro.eu>,
        airlied@...ux.ie, daniel@...ll.ch, maxime@...no.tech,
        dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: simpledrm: fix wrong unit with pixel clock

Hi

Am 12.12.21 um 17:06 schrieb Alejandro Concepcion-Rodriguez:
> Pixel clock has to be set in kHz.
> 
> Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
> 
> Signed-off-by: Alejandro Concepcion-Rodriguez <asconcepcion@...ro.eu>

Applied to drm-misc-fixes. Thanks.

Best regards
Thomas

> ---
>   drivers/gpu/drm/tiny/simpledrm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
> index 2f999915b9aa..562bf09f9140 100644
> --- a/drivers/gpu/drm/tiny/simpledrm.c
> +++ b/drivers/gpu/drm/tiny/simpledrm.c
> @@ -459,7 +459,7 @@ static struct drm_display_mode simpledrm_mode(unsigned int width,
>   {
>   	struct drm_display_mode mode = { SIMPLEDRM_MODE(width, height) };
> 
> -	mode.clock = 60 /* Hz */ * mode.hdisplay * mode.vdisplay;
> +	mode.clock = mode.hdisplay * mode.vdisplay * 60 / 1000 /* kHz */;
>   	drm_mode_set_name(&mode);
> 
>   	return mode;
> --
> 2.25.1
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)