linux-kernel - Re: [PATCH nand-next v2] mtd: rawnand: gpmi: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211213120007.6729afc4@xps13>
Date:   Mon, 13 Dec 2021 12:00:07 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     cgel.zte@...il.com
Cc:     chi.minghao@....com.cn, han.xu@....com,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        richard@....at, vigneshr@...com, zealci@....com.cn
Subject: Re: [PATCH nand-next v2] mtd: rawnand: gpmi: remove unneeded
 variable

Hello,

cgel.zte@...il.com wrote on Mon, 13 Dec 2021 10:49:30 +0000:

> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return status directly from function called.
> change since v1: mtd/nand:remove unneeded variable
>              v2: mtd: rawnand: gpmi: remove unneeded variable

Thanks for providing a changelog, this is indeed the right thing to do.
However it should not be part of the commit message and hence not be
located here...

> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---

... but here!

Anything below these three dashes '---' will be ignored by Git.

>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index 10cc71829dcb..ab9d1099bafa 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -1425,7 +1425,6 @@ static int gpmi_ecc_write_page(struct nand_chip *chip, const uint8_t *buf,
>  	struct mtd_info *mtd = nand_to_mtd(chip);
>  	struct gpmi_nand_data *this = nand_get_controller_data(chip);
>  	struct bch_geometry *nfc_geo = &this->bch_geometry;
> -	int ret;
>  
>  	dev_dbg(this->dev, "ecc write page.\n");
>  
> @@ -1445,9 +1444,7 @@ static int gpmi_ecc_write_page(struct nand_chip *chip, const uint8_t *buf,
>  				    this->auxiliary_virt);
>  	}
>  
> -	ret = nand_prog_page_op(chip, page, 0, buf, nfc_geo->page_size);
> -
> -	return ret;
> +	return nand_prog_page_op(chip, page, 0, buf, nfc_geo->page_size);
>  }
>  
>  /*


Thanks,
Miquèl