lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 Dec 2021 11:34:22 +0000
From:   Yunus Bas <Y.Bas@...tec.de>
To:     "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl: phytec: Add support for optional
 PEB-EVAL-01 board

Hi Shawn,

Sorry for the late response. I was sick for the whole week.

Am Montag, dem 06.12.2021 um 10:44 +0800 schrieb Shawn Guo:
> On Tue, Nov 30, 2021 at 09:53:53AM +0100, Yunus Bas wrote:
> > The PHYTEC PEV-EVAL-01 expansion board adds support for additional
> > gpio-triggered user-leds and gpio-key support.
> > 
> > Signed-off-by: Yunus Bas <y.bas@...tec.de>
> > ---
> >  .../boot/dts/imx6dl-phytec-mira-rdk-nand.dts  |  1 +
> >  .../boot/dts/imx6q-phytec-mira-rdk-emmc.dts   |  1 +
> >  .../boot/dts/imx6q-phytec-mira-rdk-nand.dts   |  1 +
> >  .../dts/imx6qdl-phytec-mira-peb-eval-01.dtsi  | 71
> > +++++++++++++++++++
> >  .../boot/dts/imx6qp-phytec-mira-rdk-nand.dts  |  1 +
> >  5 files changed, 75 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-
> > 01.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > b/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > index 9f7f9f98139d..b057fa664a6b 100644
> > --- a/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > +++ b/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > @@ -8,6 +8,7 @@
> >  #include "imx6dl.dtsi"
> >  #include "imx6qdl-phytec-phycore-som.dtsi"
> >  #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >  
> >  / {
> >         model = "PHYTEC phyBOARD-Mira DualLite/Solo Carrier-Board
> > with NAND";
> > diff --git a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > index 2e70ea5623c6..db6e2cc36759 100644
> > --- a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > +++ b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > @@ -8,6 +8,7 @@
> >  #include "imx6q.dtsi"
> >  #include "imx6qdl-phytec-phycore-som.dtsi"
> >  #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >  
> >  / {
> >         model = "PHYTEC phyBOARD-Mira Quad Carrier-Board with
> > eMMC";
> > diff --git a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > index 65d2e483c136..51ff601b1aec 100644
> > --- a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > +++ b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > @@ -8,6 +8,7 @@
> >  #include "imx6q.dtsi"
> >  #include "imx6qdl-phytec-phycore-som.dtsi"
> >  #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >  
> >  / {
> >         model = "PHYTEC phyBOARD-Mira Quad Carrier-Board with
> > NAND";
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-01.dtsi
> > b/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-01.dtsi
> > new file mode 100644
> > index 000000000000..3bcad402d3ec
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-01.dtsi
> > @@ -0,0 +1,71 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2018 PHYTEC Messtechnik
> > + * Author: Christian Hemp <c.hemp@...tec.de>
> > + */
> > +
> > +#include <dt-bindings/input/input.h>
> > +
> > +/ {
> > +       gpio-keys {
> > +               compatible = "gpio-keys";
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_gpio_keys>;
> > +               status = "disabled";
> > +
> > +               home {
> > +                       label = "Home";
> > +                       gpios = <&gpio6 18 GPIO_ACTIVE_LOW>;
> > +                       linux,code = <KEY_SLEEP>;
> 
> KEY_SLEEP for Home?

I'll change the node name and label in v2

> 
> Shawn
> 
> > +               };
> > +
> > +               power {
> > +                       label = "Power Button";
> > +                       gpios = <&gpio5 28 GPIO_ACTIVE_LOW>;
> > +                       linux,code = <KEY_WAKEUP>;
> > +                       wakeup-source;
> > +               };
> > +       };
> > +
> > +       user_leds: user-leds {
> > +               compatible = "gpio-leds";
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_user_leds>;
> > +               status = "disabled";
> > +
> > +               user-led1 {
> > +                       gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
> > +                       linux,default-trigger = "gpio";
> > +                       default-state = "on";
> > +               };
> > +
> > +               user-led2 {
> > +                       gpios = <&gpio7 0 GPIO_ACTIVE_HIGH>;
> > +                       linux,default-trigger = "gpio";
> > +                       default-state = "on";
> > +               };
> > +
> > +               user-led3 {
> > +                       gpios = <&gpio5 29 GPIO_ACTIVE_HIGH>;
> > +                       linux,default-trigger = "gpio";
> > +                       default-state = "on";
> > +               };
> > +       };
> > +};
> > +
> > +&iomuxc {
> > +       pinctrl_gpio_keys: gpiokeysgrp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_SD3_DAT6__GPIO6_IO18         0x1
> > b0b0
> > +                       MX6QDL_PAD_CSI0_DAT10__GPIO5_IO28       0x1
> > b0b0
> > +               >;
> > +       };
> > +
> > +       pinctrl_user_leds: userledsgrp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_SD3_DAT4__GPIO7_IO01         0x1
> > b0b0
> > +                       MX6QDL_PAD_SD3_DAT5__GPIO7_IO00         0x1
> > b0b0
> > +                       MX6QDL_PAD_CSI0_DAT11__GPIO5_IO29       0x1
> > b0b0
> > +               >;
> > +       };
> > +};
> > diff --git a/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > b/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > index f27d7ab42626..06fe0c5315fc 100644
> > --- a/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > +++ b/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > @@ -8,6 +8,7 @@
> >  #include "imx6qp.dtsi"
> >  #include "imx6qdl-phytec-phycore-som.dtsi"
> >  #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >  
> >  / {
> >         model = "PHYTEC phyBOARD-Mira QuadPlus Carrier-Board with
> > NAND";
> > -- 
> > 2.25.1
> > 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ