linux-kernel - Re: [PATCH] fs: ext2: remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211213132459.GA14044@quack2.suse.cz>
Date:   Mon, 13 Dec 2021 14:24:59 +0100
From:   Jan Kara <jack@...e.cz>
To:     Guo Zhengkui <guozhengkui@...o.com>
Cc:     Jan Kara <jack@...e.com>,
        "open list:EXT2 FILE SYSTEM" <linux-ext4@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, kernel@...o.com
Subject: Re: [PATCH] fs: ext2: remove duplicate includes

On Tue 07-12-21 16:55:24, Guo Zhengkui wrote:
> remove a duplicate "#include <linux/dax.h>"
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>

Thanks for the patch. Which kernel is it based on? Because I don't see the
duplicate line in my tree...

								Honza

> ---
>  fs/ext2/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 602578b72d8c..da4c301b4305 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -29,21 +29,20 @@
>  #include <linux/dax.h>
>  #include <linux/blkdev.h>
>  #include <linux/quotaops.h>
>  #include <linux/writeback.h>
>  #include <linux/buffer_head.h>
>  #include <linux/mpage.h>
>  #include <linux/fiemap.h>
>  #include <linux/iomap.h>
>  #include <linux/namei.h>
>  #include <linux/uio.h>
> -#include <linux/dax.h>
>  #include "ext2.h"
>  #include "acl.h"
>  #include "xattr.h"
>  
>  static int __ext2_write_inode(struct inode *inode, int do_sync);
>  
>  /*
>   * Test whether an inode is a fast symlink.
>   */
>  static inline int ext2_inode_is_fast_symlink(struct inode *inode)
> -- 
> 2.20.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR