linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Dec 2021 14:47:24 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Tudor Ambarus <tudor.ambarus@...rochip.com>
CC:     <alexandre.belloni@...tlin.com>, <ludovic.desroches@...rochip.com>,
        <robh+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock

On 09/12/2021 at 11:25, Tudor Ambarus wrote:
> Naming clocks is a good practice. The atmel-quadspi driver supports
> an unnamed clock for the peripheral clock in order to be backward
> compatible with old DTs, but it is recommended to name the clocks
> on new DTs. The driver's bindings file requires the clock-names
> property, so name the clock.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Queued in at91-dt branch for 5.17.
Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/sama5d2.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 801969c113d6..09c741e8ecb8 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -288,6 +288,7 @@ qspi0: spi@...20000 {
>   				reg-names = "qspi_base", "qspi_mmap";
>   				interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
> +				clock-names = "pclk";
>   				#address-cells = <1>;
>   				#size-cells = <0>;
>   				status = "disabled";
> @@ -299,6 +300,7 @@ qspi1: spi@...24000 {
>   				reg-names = "qspi_base", "qspi_mmap";
>   				interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 53>;
> +				clock-names = "pclk";
>   				#address-cells = <1>;
>   				#size-cells = <0>;
>   				status = "disabled";
> 


-- 
Nicolas Ferre