linux-kernel - Re: [PATCH] thunderbolt: check the return value of kmemdup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ybbo3qBRpCR2Cl93@kroah.com>
Date:   Mon, 13 Dec 2021 07:31:58 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Xiaoke Wang <xkernel.wang@...mail.com>
Cc:     linux-usb <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "andreas.noever" <andreas.noever@...il.com>,
        "michael.jamet" <michael.jamet@...el.com>,
        "mika.westerberg" <mika.westerberg@...ux.intel.com>,
        YehezkelShB <YehezkelShB@...il.com>
Subject: Re: [PATCH] thunderbolt: check the return value of kmemdup()

On Mon, Dec 13, 2021 at 02:27:28PM +0800, Xiaoke Wang wrote:
> On Mon, Dec 13, 2021 02:10 PM, Greg KH wrote:
> > kmemdup() return NULL when some internal memory errors happen, it is
> > better to check the return value of it. Otherwise, some memory errors
> > will not be catched in time and may further result in wrong memory> access.
> > 
> > Signed-off-by: xkernel <xkernel.wang@...mail.com>
> >
> > Please use your "full" name, I doubt you sign documents as "xkernel". :)
> >
> > thanks,
> >
> > greg k-h
> 
> I am very sorry about that, my full name is "Xiaoke Wang".

Great, please fix up and resend (also fix the From: line in your email
client to show that.)

thanks,

greg k-h