linux-kernel - [PATCH v3] fpga: stratix10-soc: fix NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211213064900.10386-1-linmq006@gmail.com>
Date:   Mon, 13 Dec 2021 06:49:00 +0000
From:   Miaoqian Lin <linmq006@...il.com>
To:     hao.wu@...el.com
Cc:     linmq006@...il.com, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, mdf@...nel.org, trix@...hat.com,
        yilun.xu@...el.com
Subject: [PATCH v3] fpga: stratix10-soc: fix NULL vs IS_ERR() checking

The stratix10_svc_allocate_memory function does not return NULL. It
returns ERR_PTR(-ENOMEM). Use IS_ERR check the return value.

Fixes: e7eef1d7633a("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
Reviewed-by: Tom Rix <trix@...hat.com>
Acked-by: Xu Yilun <yilun.xu@...el.com>
Acked-by: Wu Hao <hao.wu@...el.com>
---
 drivers/fpga/stratix10-soc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 047fd7f23706..91212bab5871 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
 	/* Allocate buffers from the service layer's pool. */
 	for (i = 0; i < NUM_SVC_BUFS; i++) {
 		kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
-		if (!kbuf) {
+		if (IS_ERR(kbuf)) {
 			s10_free_buffers(mgr);
-			ret = -ENOMEM;
+			ret = PTR_ERR(kbuf);
 			goto init_done;
 		}
 
-- 
2.17.1