lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20211213164518.2461-1-hanshenghong2019@email.szu.edu.cn>
Date:   Tue, 14 Dec 2021 00:45:18 +0800
From:   Shenghong Han <hanshenghong2019@...il.szu.edu.cn>
To:     akpm@...ux-foundation.org
Cc:     broonie@...nel.org, seanga2@...il.com, weizhenliang@...wei.com,
        tangbin@...s.chinamobile.com, zhangshengju@...s.chinamobile.com,
        zhaochongxi2019@...il.szu.edu.cn, zhangyinan2019@...il.szu.edu.cn,
        linux-kernel@...r.kernel.org, caoyixuan2019@...il.szu.edu.cn,
        hanshenghong2019@...il.szu.edu.cn
Subject: [PATCH 2/2] tools/vm/page_owner_sort.c: two trivial fixes

1) There is an unused variable. It's better to delete it.
2) One case is missing in the usage().

Signed-off-by: Shenghong Han <hanshenghong2019@...il.szu.edu.cn>
---
 tools/vm/page_owner_sort.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
index c16774f09eeb..a2c6797e09f8 100644
--- a/tools/vm/page_owner_sort.c
+++ b/tools/vm/page_owner_sort.c
@@ -41,8 +41,6 @@ static struct block_list *list;
 static int list_size;
 static int max_size;
 
-struct block_list *block_head;
-
 int read_block(char *buf, int buf_size, FILE *fin)
 {
 	char *curr = buf, *const buf_end = buf + buf_size;
@@ -249,7 +247,8 @@ static void usage(void)
 		"-p	Sort by pid.\n"
 		"-a	Sort by memory allocate time.\n"
 		"-r	Sort by memory release time.\n"
-		"-c	cull by comparing stacktrace instead of total block.\n"
+		"-c	Cull by comparing stacktrace instead of total block.\n"
+		"-f	Filter out the information of blocks whose memory has not been released.\n"
 	);
 }
 
-- 
2.30.1



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ