linux-kernel - Re: [PATCH V5 4/6] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ybd+UKPH53hkeNcV@robh.at.kernel.org>
Date:   Mon, 13 Dec 2021 11:09:36 -0600
From:   Rob Herring <robh@...nel.org>
To:     Charles Mirabile <cmirabil@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Joel Savitz <jsavitz@...hat.com>,
        Lee Jones <lee.jones@...aro.org>,
        Mwesigwa Guma <mguma@...hat.com>,
        Nicolas Saenz Julienne <nsaenzju@...hat.com>,
        Serge Schneider <serge@...pberrypi.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org,
        Mattias Brugger <mbrugger@...e.com>,
        fedora-rpi@...glegroups.com,
        Stefan Wahren <stefan.wahren@...e.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH V5 4/6] dt-bindings: mfd: sensehat: Add Raspberry Pi
 Sense HAT schema

On Sat, Dec 11, 2021 at 01:59:31PM -0600, Rob Herring wrote:
> On Fri, 10 Dec 2021 17:10:31 -0500, Charles Mirabile wrote:
> > This patch adds the device tree binding
> > for the Sense HAT in yaml form.
> > 
> > Signed-off-by: Charles Mirabile <cmirabil@...hat.com>
> > Co-developed-by: Mwesigwa Guma <mguma@...hat.com>
> > Signed-off-by: Mwesigwa Guma <mguma@...hat.com>
> > Co-developed-by: Joel Savitz <jsavitz@...hat.com>
> > Signed-off-by: Joel Savitz <jsavitz@...hat.com>
> > ---
> >  .../bindings/mfd/raspberrypi,sensehat.yaml    | 54 +++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml:2:1: [error] missing document start "---" (document-start)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml: properties:interrupt-parent: False schema does not allow {'items': [{'description': 'gpio pin bank for interrupt pin'}]}
> 	from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml#
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml: ignoring, error in schema: properties: interrupt-parent
> warning: no schema found in file: ./Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.example.dt.yaml:0:0: /example-0/i2c/sensehat@46: failed to match any schema with compatible: ['raspberrypi,sensehat']

'interrupt-parent' is not needed as it is always valid or could be in a 
parent node.