linux-kernel - Re: [PATCH v3 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Dec 2021 10:12:38 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jason Self <jason@...ehome.net>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Ryutaroh Matsumoto <ryutaroh@....e.titech.ac.jp>,
        Xuefeng Li <lixuefeng@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC
 option

On Mon, Dec 13, 2021 at 05:57:56PM +0800, Tiezhu Yang wrote:
> According to the document "Minimal requirements to compile the Kernel [1],
> the minimal version of GCC is 5.1, -mr10k-cache-barrier=store is supported
> with GCC 5.1 [2], so just remove the unnecessary check to fix the build
> error [3]:
> 
>   arch/mips/sgi-ip22/Platform:28: *** gcc doesn't support needed option -mr10k-cache-barrier=store.  Stop.
> 
> [1] https://www.kernel.org/doc/html/latest/process/changes.html
> [2] https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/MIPS-Options.html
> [3] https://github.com/ClangBuiltLinux/linux/issues/1543
> 
> Reported-by: Ryutaroh Matsumoto <ryutaroh@....e.titech.ac.jp>
> Suggested-by: Nathan Chancellor <nathan@...nel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Thanks for sending this!

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  arch/mips/sgi-ip22/Platform | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/mips/sgi-ip22/Platform b/arch/mips/sgi-ip22/Platform
> index 62fa30b..a4c46e3 100644
> --- a/arch/mips/sgi-ip22/Platform
> +++ b/arch/mips/sgi-ip22/Platform
> @@ -23,10 +23,5 @@ endif
>  # be 16kb aligned or the handling of the current variable will break.
>  # Simplified: what IP22 does at 128MB+ in ksegN, IP28 does at 512MB+ in xkphys
>  #
> -ifdef CONFIG_SGI_IP28
> -  ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
> -      $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
> -  endif
> -endif
>  cflags-$(CONFIG_SGI_IP28)	+= -mr10k-cache-barrier=store -I$(srctree)/arch/mips/include/asm/mach-ip28
>  load-$(CONFIG_SGI_IP28)		+= 0xa800000020004000
> -- 
> 2.1.0
>