[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211213194906.00fd028c@aktux>
Date: Mon, 13 Dec 2021 19:49:06 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Alistair Francis <alistair23@...il.com>,
Alistair Francis <alistair@...stair23.me>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
devicetree <devicetree@...r.kernel.org>,
linux-input <linux-input@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Mylene Josserand <mylene.josserand@...e-electrons.com>,
Linus Walleij <linus.walleij@...aro.org>,
Henrik Rydberg <rydberg@...math.org>,
Rob Herring <robh+dt@...nel.org>,
Mylène Josserand <mylene.josserand@...tlin.com>,
Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5
touchscreen
Hi,
On Sun, 12 Dec 2021 21:45:48 -0800
Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
> > > > + rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq,
> > > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > >
> > > Please do not override platform setup with hardcoded triggers. Also, it
> > > is strongly recommended to use level interrupts for these peripherals.
> > >
> > > This is also likely unsafe if controller is not completely shut off and
> > > is capable of generating interrupts given input device is not yet
> > > allocated.
> >
> > I have dropped the `IRQF_TRIGGER_FALLING |`
> >
> > I have tried to use level interrupts, but I can't get the device
> > working with them.
>
> That is weird, does the interrupt controller support level interrupts?
>
hmm, it should, at least on the imx6 I am using them for some other
devices, I guess, on the imx7 they should work, too.
I hope I find time to give that a try the next days.
Regards,
Andreas
Powered by blists - more mailing lists