linux-kernel - Re: [PATCH v2] fpga: stratix10-soc: fix NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Dec 2021 09:28:18 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Tom Rix <trix@...hat.com>
Cc:     Miaoqian Lin <linmq006@...il.com>, hao.wu@...el.com,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        mdf@...nel.org
Subject: Re: [PATCH v2] fpga: stratix10-soc: fix NULL vs IS_ERR() checking

On Sat, Dec 11, 2021 at 06:57:51AM -0800, Tom Rix wrote:
> 
> On 12/11/21 6:50 AM, Miaoqian Lin wrote:
> > The stratix10_svc_allocate_memory function does not return NULL. It
> > returns ERR_PTR(-ENOMEM). Use IS_ERR check the return value.
> > 
> > Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> > ---
> >   drivers/fpga/stratix10-soc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 047fd7f23706..91212bab5871 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
> >   	/* Allocate buffers from the service layer's pool. */
> >   	for (i = 0; i < NUM_SVC_BUFS; i++) {
> >   		kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
> > -		if (!kbuf) {
> > +		if (IS_ERR(kbuf)) {
> >   			s10_free_buffers(mgr);
> > -			ret = -ENOMEM;
> > +			ret = PTR_ERR(kbuf);
> 
> Thanks!
> 
> Reviewed-by: Tom Rix <trix@...hat.com>

Acked-by: Xu Yilun <yilun.xu@...el.com>

Thanks,
Yilun

> 
> >   			goto init_done;
> >   		}