linux-kernel - Re: [PATCH] cgroup: return early if it is already on preloaded list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbeekNeegXoP6F93@slm.duckdns.org>
Date:   Mon, 13 Dec 2021 09:27:12 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Wei Yang <richard.weiyang@...il.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: return early if it is already on preloaded list

On Sat, Dec 11, 2021 at 04:17:29PM +0000, Wei Yang wrote:
> If it is already on preloaded list, this means we have already setup
> this cset properly for migration.
> 
> Let's skip this cset on this condition.

The patch looks fine but I think description can be improved. Can you just
say that it's just relocating the root cgrp lookup which isn't used anyway
when the cset is already on the preloaded list?

Thanks.

-- 
tejun