linux-kernel - Re: [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+5nM2L=p13CSq8FRZX0sMykbXdyBatDR7McUXkv5NXzA@mail.gmail.com>
Date:   Mon, 13 Dec 2021 13:30:36 -0600
From:   Rob Herring <robh@...nel.org>
To:     呂芳騰 <wellslutw@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Wells Lu <wells.lu@...plus.com>,
        Vincent Shih <vincent.shih@...plus.com>
Subject: Re: [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings
 doc for Sunplus SP7021.

On Sat, Dec 11, 2021 at 1:35 PM 呂芳騰 <wellslutw@...il.com> wrote:
>
> Hi Rob,
>
> Thank you very much for your review.
> Please see my replies below:
>
> > Add bindings documentation for Sunplus SP7021.
> >
> [...]
> > > +
> > > +  interrupts:
> > > +    description: |
> > > +      Contains number and type of interrupt. Number should be 66.
> >
> > Drop. That's every 'interrupts' and the exact number is outside the
> > scope of the binding.
>
> Yes, I'll drop the descriptions next patch.
> interrupts property will be:
>
>   interrupts:
>     maxItems: 1
>
>
> [...]
> > > +
> > > +  mdio:
> >
> > Just need:
> >
> >        $ref: mdio.yaml#
> >        unevaluatedProperties: false
> >
> > and drop the rest.
>
> Yes, I'll modify mdio node next patch.
> mdio node will be:
>
>   mdio:
>     $ref: mdio.yaml#
>     unevaluatedProperties: false
>
>
> > > +    type: object
> > > +    description: external MDIO Bus
> > > +
> > > +    properties:
> > > +      "#address-cells":
> > > +        const: 1
> > > +
> > > +      "#size-cells":
> > > +        const: 0
> > > +
> > > +    patternProperties:
> > > +      "^ethernet-phy@[0-9a-f]+$":
> > > +        type: object
> > > +        description: external PHY node
> > > +
> > > +        properties:
> > > +          reg:
> > > +            minimum: 0
> > > +            maximum: 30
>
> Can I limit value of 'reg' to no more than 30?

Isn't that the limit for any MDIO bus? I guess normally 31 is also
valid? I'm not really sure it is worth adding just for that 1 possible
value. Within the range of valid addresses, we can't ever validate
that a DT has the correct address.

Rob