linux-kernel - Re: [PATCH] rcu: Remove unused rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211213194153.GS641268@paulmck-ThinkPad-P17-Gen-1>
Date:   Mon, 13 Dec 2021 11:41:53 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Neeraj Upadhyay <quic_neeraju@...cinc.com>
Cc:     josh@...htriplett.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        joel@...lfernandes.org, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org, urezki@...il.com,
        frederic@...nel.org, boqun.feng@...il.com
Subject: Re: [PATCH] rcu: Remove unused rcu_state.boost

On Mon, Dec 13, 2021 at 12:32:09PM +0530, Neeraj Upadhyay wrote:
> Signed-off-by: Neeraj Upadhyay <quic_neeraju@...cinc.com>

Good eyes!  This has since been replaced by the ->can_boost field of
the rcu_torture_ops structure.

Queued for review and testing, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tree.h        | 5 ++---
>  kernel/rcu/tree_plugin.h | 2 --
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 4b889081f4f4..caea946700f3 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -303,9 +303,8 @@ struct rcu_state {
>  
>  	/* The following fields are guarded by the root rcu_node's lock. */
>  
> -	u8	boost ____cacheline_internodealigned_in_smp;
> -						/* Subject to priority boost. */
> -	unsigned long gp_seq;			/* Grace-period sequence #. */
> +	unsigned long gp_seq ____cacheline_internodealigned_in_smp;
> +						/* Grace-period sequence #. */
>  	unsigned long gp_max;			/* Maximum GP duration in */
>  						/*  jiffies. */
>  	struct task_struct *gp_kthread;		/* Task for grace periods. */
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 1439cb3680eb..54ef0e8c8742 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1174,8 +1174,6 @@ static void rcu_spawn_one_boost_kthread(struct rcu_node *rnp)
>  	if (rnp->boost_kthread_task || !rcu_scheduler_fully_active)
>  		goto out;
>  
> -	rcu_state.boost = 1;
> -
>  	t = kthread_create(rcu_boost_kthread, (void *)rnp,
>  			   "rcub/%d", rnp_index);
>  	if (WARN_ON_ONCE(IS_ERR(t)))
> -- 
> 2.17.1
>