lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 13 Dec 2021 14:01:46 -0600
From:   Alex Elder <elder@...e.org>
To:     Jason Wang <wangborong@...rlc.com>, elder@...nel.org
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] greybus: es2: fix typo in a comment

On 12/11/21 9:16 PM, Jason Wang wrote:
> The double `for' in the comment in line 81 is repeated. Remove one
> of them from the comment.

This looks fine.  But it's so trivial...  Are you aware
of *any* other similar trivial problems in comments that
could be fixed together with this?  If so, I would prefer
that.

If you've looked, and there are no others:

Reviewed-by: Alex Elder <elder@...aro.org>


> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>   drivers/greybus/es2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c
> index 15661c7f3633..e89cca015095 100644
> --- a/drivers/greybus/es2.c
> +++ b/drivers/greybus/es2.c
> @@ -78,7 +78,7 @@ struct es2_cport_in {
>    * @hd: pointer to our gb_host_device structure
>    *
>    * @cport_in: endpoint, urbs and buffer for cport in messages
> - * @cport_out_endpoint: endpoint for for cport out messages
> + * @cport_out_endpoint: endpoint for cport out messages
>    * @cport_out_urb: array of urbs for the CPort out messages
>    * @cport_out_urb_busy: array of flags to see if the @cport_out_urb is busy or
>    *			not.
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ