linux-kernel - Re: [PATCH v6 01/17] ima: Add IMA namespace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4249c5d-da3d-4306-8d9b-10f06ec80cba@linux.ibm.com>
Date:   Mon, 13 Dec 2021 16:11:16 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     linux-integrity@...r.kernel.org
Cc:     zohar@...ux.ibm.com, serge@...lyn.com,
        christian.brauner@...ntu.com, containers@...ts.linux.dev,
        dmitry.kasatkin@...il.com, ebiederm@...ssion.com,
        krzysztof.struczynski@...wei.com, roberto.sassu@...wei.com,
        mpeters@...hat.com, lhinds@...hat.com, lsturman@...hat.com,
        puiterwi@...hat.com, jejb@...ux.ibm.com, jamjoom@...ibm.com,
        linux-kernel@...r.kernel.org, paul@...l-moore.com, rgb@...hat.com,
        linux-security-module@...r.kernel.org, jmorris@...ei.org,
        James Bottomley <James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH v6 01/17] ima: Add IMA namespace support


On 12/10/21 14:47, Stefan Berger wrote:
> Implement an IMA namespace data structure that gets created alongside a
> user namespace with CLONE_NEWUSER. This lays down the foundation for
> namespacing the different aspects of IMA (eg. IMA-audit, IMA-measurement,
> IMA-appraisal).
>
> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> Suggested-by: James Bottomley <James.Bottomley@...senPartnership.com>
> ---
>   include/linux/ima.h                      | 37 +++++++++++++
>   include/linux/user_namespace.h           |  4 ++
>   init/Kconfig                             | 10 ++++
>   kernel/user.c                            |  7 +++
>   kernel/user_namespace.c                  |  8 +++
>   security/integrity/ima/Makefile          |  3 +-
>   security/integrity/ima/ima.h             |  4 ++
>   security/integrity/ima/ima_init.c        |  4 ++
>   security/integrity/ima/ima_init_ima_ns.c | 32 +++++++++++
>   security/integrity/ima/ima_ns.c          | 69 ++++++++++++++++++++++++
>   10 files changed, 177 insertions(+), 1 deletion(-)
>   create mode 100644 security/integrity/ima/ima_init_ima_ns.c
>   create mode 100644 security/integrity/ima/ima_ns.c
>
> diff --git a/include/linux/ima.h b/include/linux/ima.h
> index b6ab66a546ae..f282e40c316c 100644
> --- a/include/linux/ima.h
> +++ b/include/linux/ima.h
> @@ -11,6 +11,7 @@
>   #include <linux/fs.h>
>   #include <linux/security.h>
>   #include <linux/kexec.h>
> +#include <linux/user_namespace.h>
>   #include <crypto/hash_info.h>
>   struct linux_binprm;
>   
> @@ -210,6 +211,42 @@ static inline int ima_inode_removexattr(struct dentry *dentry,
>   }
>   #endif /* CONFIG_IMA_APPRAISE */
>   
> +struct ima_namespace {
> +	int avoid_zero_size;
> +};


I moved the structure to security/integrity/ima/ima.h for v7 and added 
__randomize_layout to it.

   Stefan