linux-kernel - Re: [PATCH v2] scsi: pm8001: Fix phys_to_virt() usage on dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63cc50a5-b7ce-5930-68f1-039a71178b48@huawei.com>
Date:   Mon, 13 Dec 2021 09:16:02 +0000
From:   John Garry <john.garry@...wei.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <jinpu.wang@...ud.ionos.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <Viswas.G@...rochip.com>, <Ajish.Koshy@...rochip.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: pm8001: Fix phys_to_virt() usage on dma_addr_t

On 11/12/2021 00:26, Damien Le Moal wrote:
>> ss
>> @@ -4320,20 +4324,20 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha,
>>   		pm8001_dbg(pm8001_ha, IO, "SMP REQUEST DIRECT MODE\n");
>>   		for (i = 0; i < length; i++)
>>   			if (i < 16) {
>> -				smp_cmd.smp_req16[i] = *(preq_dma_addr+i);
>> +				smp_cmd.smp_req16[i] = *(payload+i);
> Maybe add spacs around the "+" as you did above ?

Yeah, right. I noticed now that only strict mode of checkpatch picks up 
on this.

> 
>>   				pm8001_dbg(pm8001_ha, IO,
>>   					   "Byte[%d]:%x (DMA data:%x)\n",
>>   					   i, smp_cmd.smp_req16[i],

...

>>   	}
>> -
>> +	kunmap_atomic(to);
>>   	build_smp_cmd(pm8001_dev->device_id, smp_cmd.tag,
>>   				&smp_cmd, pm8001_ha->smp_exp_mode, length);
>>   	rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &smp_cmd,
> Otherwise, looks OK to me.

cheers