linux-kernel - Re: [PATCH] tracing: Account bottom half disabled sections.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbcSLmrm0HmCJzvJ@linutronix.de>
Date:   Mon, 13 Dec 2021 10:28:14 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] tracing: Account bottom half disabled sections.

On 2021-12-10 20:32:40 [-0500], Steven Rostedt wrote:
> > @@ -4226,7 +4228,7 @@ static void print_func_help_header_irq(struct array_buffer *buf, struct seq_file
> >  
> >  	seq_printf(m, "#                            %.*s  _-----=> irqs-off\n", prec, space);
> >  	seq_printf(m, "#                            %.*s / _----=> need-resched\n", prec, space);
> > -	seq_printf(m, "#                            %.*s| / _---=> hardirq/softirq\n", prec, space);
> > +	seq_printf(m, "#                            %.*s| / _---=> hardirq/softirq/BH-disabled\n", prec, space);
> 
> So I went to update the documentation on this, and realized that this is
> wrong. Really, we want this in the irqs-off section probably.
> 
> Note, the above is to show we are running in a hardirq or softirq context.
> But BH-disabled does not match that. Should this be with irqs-off being:
> 
>  d - irqs are disabled
>  b - BH is disabled?
>  D - irqs and BH is disabled?

We are not in hardirq/softirq/nmi but have simply BH disabled.
Makes sense.

> -- Steve

Sebastian