[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hlf0oeti5.wl-tiwai@suse.de>
Date: Mon, 13 Dec 2021 10:36:34 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: drivers: opl3: Fix incorrect use of vp->state
On Sun, 12 Dec 2021 18:20:25 +0100,
Colin Ian King wrote:
>
> Static analysis with scan-build has found an assignment to vp2 that is
> never used. It seems that the check on vp->state > 0 should be actually
> on vp2->state instead. Fix this.
>
> This dates back to 2002, I found the offending commit from the git
> history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
> commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Thanks, applied now with Cc-to-stable.
Takashi
Powered by blists - more mailing lists