linux-kernel - Re: [PATCH] ALSA: jack: Check the return value of kstrdup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hk0g8etbk.wl-tiwai@suse.de>
Date:   Mon, 13 Dec 2021 10:40:31 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Xiaoke Wang <xkernel.wang@...mail.com>
Cc:     joe@...ches.com, perex@...ex.cz, tiwai@...e.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: jack: Check the return value of kstrdup()

On Mon, 13 Dec 2021 08:39:31 +0100,
Xiaoke Wang wrote:
> 
> kstrdup() can return NULL, it is better to check the return value of it.
> Fix: free jack and use my full name.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>

Thanks, applied now with Cc-to-stable.

BTW, when you submit a revised patch, please put 'v2' or such to the
patch subject prefix, e.g.
  [PATCH v2] ALSA: jack: ...

Also you can put the note about the changes between revisions as

  v1->v2: Fix something more....

and this could be put after the first '---' line (around the diffstat)
if it's not necessarily to be included in the final commit log.


Takashi