linux-kernel - Re: [PATCH net] rds: memory leak in __rds_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <017A6000-BEAA-4684-9A3B-BE7FC40E1DB1@oracle.com>
Date:   Tue, 14 Dec 2021 17:39:29 +0000
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Hangyu Hua <hbh25y@...il.com>
CC:     "David S . Miller" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] rds: memory leak in __rds_conn_create()



> On Dec 14, 2021, at 2:46 AM, Hangyu Hua <hbh25y@...il.com> wrote:
> 
> __rds_conn_create() did not release conn->c_path when loop_trans != 0 and
> trans->t_prefer_loopback != 0 and is_outgoing == 0.
> 
> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> ---
> net/rds/connection.c | 1 +
> 1 file changed, 1 insertion(+)

Looks good to me. Thanks !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>