linux-kernel - Re: [PATCH 2/2] ASoC: Add AK4375 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa40932c2dfbfcbdefa976f9609bdfca10fdd9cf.camel@mailoo.org>
Date:   Tue, 14 Dec 2021 19:28:19 +0100
From:   Vincent Knecht <vincent.knecht@...loo.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        obayerd@...ocomposant.fr, phone-devel@...r.kernel.org,
        stephan@...hold.net, linux-kernel@...r.kernel.org, tiwai@...e.com,
        lgirdwood@...il.com, robh+dt@...nel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/2] ASoC: Add AK4375 support

Le lundi 13 décembre 2021 à 19:07 +0000, Mark Brown a écrit :
> On Mon, Dec 13, 2021 at 04:59:12PM +0100, Vincent Knecht wrote:
> 
> > AK4375 is a 32-bit stereo DAC with headphones amplifier.
> > There's no documentation for it on akm.com, and only a brief
> > datasheet can be found floating on the internets [1].
> 
> This driver looks relatively clean but it's in *serious* need of
> modernisation, there's issues here that haven't been present upstream
> for a very long time.  Fortunately they're mostly style things so it
> should be relatively easy to handle.

Thank you Mark for this review, hopefully I'll fix all points
and submit a v2 within a week or so.