linux-kernel - Re: [PATCH v2 06/10] arm64: dts: lx2160a: add pcie EP mode nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211214054044.GG10916@dragon>
Date:   Tue, 14 Dec 2021 13:40:45 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Li Yang <leoyang.li@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Xiaowei Bao <xiaowei.bao@....com>,
        Hou Zhiqiang <Zhiqiang.Hou@....com>
Subject: Re: [PATCH v2 06/10] arm64: dts: lx2160a: add pcie EP mode nodes

On Fri, Dec 03, 2021 at 05:54:42PM -0600, Li Yang wrote:
> From: Xiaowei Bao <xiaowei.bao@....com>
> 
> The LX2160A PCIe EP mode nodes based on controller used on lx2160a rev2.
> 
> Signed-off-by: Xiaowei Bao <xiaowei.bao@....com>
> Signed-off-by: Li Yang <leoyang.li@....com>
> Reviewed-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> ---
>  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index de680521e1d1..593c5a498ae3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -1115,6 +1115,16 @@ pcie1: pcie@...0000 {
>  			status = "disabled";
>  		};
>  
> +		pcie_ep1: pcie_ep@...0000 {

Hyphen is more recommended than underscore for node name.

Shawn

> +			compatible = "fsl,lx2160ar2-pcie-ep", "fsl,ls-pcie-ep";
> +			reg = <0x00 0x03400000 0x0 0x00100000
> +			       0x80 0x00000000 0x8 0x00000000>;
> +			reg-names = "regs", "addr_space";
> +			num-ob-windows = <8>;
> +			num-ib-windows = <8>;
> +			status = "disabled";
> +		};
> +
>  		pcie2: pcie@...0000 {
>  			compatible = "fsl,ls2088a-pcie";
>  			reg = <0x00 0x03500000 0x0 0x00100000   /* controller registers */
> @@ -1143,6 +1153,16 @@ pcie2: pcie@...0000 {
>  			status = "disabled";
>  		};
>  
> +		pcie_ep2: pcie_ep@...0000 {
> +			compatible = "fsl,lx2160ar2-pcie-ep", "fsl,ls-pcie-ep";
> +			reg = <0x00 0x03500000 0x0 0x00100000
> +			       0x88 0x00000000 0x8 0x00000000>;
> +			reg-names = "regs", "addr_space";
> +			num-ob-windows = <8>;
> +			num-ib-windows = <8>;
> +			status = "disabled";
> +		};
> +
>  		pcie3: pcie@...0000 {
>  			compatible = "fsl,ls2088a-pcie";
>  			reg = <0x00 0x03600000 0x0 0x00100000   /* controller registers */
> @@ -1171,6 +1191,16 @@ pcie3: pcie@...0000 {
>  			status = "disabled";
>  		};
>  
> +		pcie_ep3: pcie_ep@...0000 {
> +			compatible = "fsl,lx2160ar2-pcie-ep", "fsl,ls-pcie-ep";
> +			reg = <0x00 0x03600000 0x0 0x00100000
> +			       0x90 0x00000000 0x8 0x00000000>;
> +			reg-names = "regs", "addr_space";
> +			num-ob-windows = <256>;
> +			num-ib-windows = <24>;
> +			status = "disabled";
> +		};
> +
>  		pcie4: pcie@...0000 {
>  			compatible = "fsl,ls2088a-pcie";
>  			reg = <0x00 0x03700000 0x0 0x00100000   /* controller registers */
> @@ -1199,6 +1229,16 @@ pcie4: pcie@...0000 {
>  			status = "disabled";
>  		};
>  
> +		pcie_ep4: pcie_ep@...0000 {
> +			compatible = "fsl,lx2160ar2-pcie-ep", "fsl,ls-pcie-ep";
> +			reg = <0x00 0x03700000 0x0 0x00100000
> +			       0x98 0x00000000 0x8 0x00000000>;
> +			reg-names = "regs", "addr_space";
> +			num-ob-windows = <8>;
> +			num-ib-windows = <8>;
> +			status = "disabled";
> +		};
> +
>  		pcie5: pcie@...0000 {
>  			compatible = "fsl,ls2088a-pcie";
>  			reg = <0x00 0x03800000 0x0 0x00100000   /* controller registers */
> @@ -1227,6 +1267,16 @@ pcie5: pcie@...0000 {
>  			status = "disabled";
>  		};
>  
> +		pcie_ep5: pcie_ep@...0000 {
> +			compatible = "fsl,lx2160ar2-pcie-ep", "fsl,ls-pcie-ep";
> +			reg = <0x00 0x03800000 0x0 0x00100000
> +			       0xa0 0x00000000 0x8 0x00000000>;
> +			reg-names = "regs", "addr_space";
> +			num-ob-windows = <256>;
> +			num-ib-windows = <24>;
> +			status = "disabled";
> +		};
> +
>  		pcie6: pcie@...0000 {
>  			compatible = "fsl,ls2088a-pcie";
>  			reg = <0x00 0x03900000 0x0 0x00100000   /* controller registers */
> @@ -1255,6 +1305,16 @@ pcie6: pcie@...0000 {
>  			status = "disabled";
>  		};
>  
> +		pcie_ep6: pcie_ep@...0000 {
> +			compatible = "fsl,lx2160ar2-pcie-ep", "fsl,ls-pcie-ep";
> +			reg = <0x00 0x03900000 0x0 0x00100000
> +			       0xa8 0x00000000 0x8 0x00000000>;
> +			reg-names = "regs", "addr_space";
> +			num-ob-windows = <8>;
> +			num-ib-windows = <8>;
> +			status = "disabled";
> +		};
> +
>  		smmu: iommu@...0000 {
>  			compatible = "arm,mmu-500";
>  			reg = <0 0x5000000 0 0x800000>;
> -- 
> 2.25.1
>