linux-kernel - Re: [RESEND PATCH v3 10/10] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b320028-33a7-4d3a-c671-8db80d061e47@quicinc.com>
Date:   Tue, 14 Dec 2021 13:50:10 +0800
From:   Fenglin Wu <quic_fenglinw@...cinc.com>
To:     Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Subbaraman Narayanamurthy <quic_subbaram@...cinc.com>,
        <collinsd@...eaurora.org>, Andy Gross <agross@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <subbaram@...eaurora.org>, <tglx@...utronix.de>, <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [RESEND PATCH v3 10/10] dt-bindings: convert qcom,spmi-pmic-arb
 binding to YAML format

Sorry for late response. I had a check in the log and tried "make 
dtbs_check" at my side.
There are 5 types of warnings, I guess I can fix two types of them.

1) : qcom,spmi@...f000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3' do not 
match any of the regexes: 'pinctrl-[0-9]+'

This indicates the child nodes devices are not recognized, this can be 
fixed by adding pattern
properties similar to what defines in spmi.yaml. I will address it in 
next patchset.

2) qcom,spmi@...f000: reg-names: 'oneOf' conditional failed, one must be 
fixed:

This is because of the "items" defined in "reg-name" does not match 
between the dtsi nodes
and the schema in sequence wise. I will update the scheme for "reg-name" 
like this to fix it in
next patchset:
   reg-names:
     anyOf:
       - minItems: 3
       - maxItems: 3
       - enum: ["core", "intr", "cnfg"]

       - minItems: 5
       - maxItems: 5
       - enum: ["core", "intr", "cnfg", "chnls", "obsrvr"]

3) qcom,spmi@...f000: $nodename:0: 'qcom,spmi@...f000' does not match 
'^spmi@.*'

This indicates the mismatch of the device node name between the dtsi and 
schema, I guess
the fix should be in dtsi file instead of this binding, the spmi.yaml 
file has defined
the nodename with "spmi@" prefix, qcom,spmi-pmic-arb.yaml should follow 
this.
Should I make the change and update all the nodes names in dtsi file 
like this? Or can this
be ignored and leave it to dtsi file owners to update them accordingly?

4) spmi@...0000: #address-cells:0:0: 2 was expected
   spmi@...0000: #size-cells:0:0: 0 was expected

Some of the spmi device nodes specify #address-cell = < 1>, and 
#size-cell = <1>, the original
.txt binding specified #address-cell = < 2>, and #size-cell = <0>. The 
change should be in dtsi
to update them following the binding. Let me know if I should do this, 
or I can leave itto the
dtsi file owners to update them accordingly.

5) spmi@...0000: 'cell-index' does not match any of the regexes: 
'pinctrl-[0-9]+'

"cell-index" is not used in the driver, also it doesn't exist in the 
.txt binding, so this should
be fixedin the corresponding dtsi file. Let me know if I need to fix it.

Thanks


On 2021/12/10 10:05, Stephen Boyd wrote:
> Quoting Rob Herring (2021-12-02 05:58:09)
>> On Thu, 02 Dec 2021 08:00:12 +0800, Fenglin Wu wrote:
>>> Convert the SPMI PMIC arbiter documentation to JSON/yaml. While at it,
>>> update SPMI bus "reg" items constraint for SPMI PMIC arbiter to carry
>>> it and update it with a smaller range.
>>>
>>> Signed-off-by: Fenglin Wu <quic_fenglinw@...cinc.com>
>>> ---
>>>   .../bindings/spmi/qcom,spmi-pmic-arb.txt           |  67 -----------
>>>   .../bindings/spmi/qcom,spmi-pmic-arb.yaml          | 128 +++++++++++++++++++++
>>>   Documentation/devicetree/bindings/spmi/spmi.yaml   |   3 +-
>>>   3 files changed, 130 insertions(+), 68 deletions(-)
>>>   delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>>>   create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1562483
> Are any of these problems going to be fixed?