linux-kernel - RE: [External] : [PATCH v3 ocrdma-next] drivers: ocrdma: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR10MB5635347074DDA51CF2766B9DDD759@CO6PR10MB5635.namprd10.prod.outlook.com>
Date:   Tue, 14 Dec 2021 08:43:39 +0000
From:   Devesh Sharma <devesh.s.sharma@...cle.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>
CC:     "chi.minghao@....com.cn" <chi.minghao@....com.cn>,
        "dennis.dalessandro@...nelisnetworks.com" 
        <dennis.dalessandro@...nelisnetworks.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "mbloch@...dia.com" <mbloch@...dia.com>,
        "selvin.xavier@...adcom.com" <selvin.xavier@...adcom.com>,
        "trix@...hat.com" <trix@...hat.com>
Subject: RE: [External] : [PATCH v3 ocrdma-next] drivers: ocrdma: remove
 unneeded variable



> -----Original Message-----
> From: cgel.zte@...il.com <cgel.zte@...il.com>
> Sent: Tuesday, December 14, 2021 1:41 PM
> To: Devesh Sharma <devesh.s.sharma@...cle.com>
> Cc: cgel.zte@...il.com; chi.minghao@....com.cn;
> dennis.dalessandro@...nelisnetworks.com; dledford@...hat.com;
> galpress@...zon.com; jgg@...pe.ca; leon@...nel.org; linux-
> kernel@...r.kernel.org; linux-rdma@...r.kernel.org; mbloch@...dia.com;
> selvin.xavier@...adcom.com; trix@...hat.com; zealci@....com.cm; Zeal
> Robot <zealci@....com.cn>
> Subject: [External] : [PATCH v3 ocrdma-next] drivers: ocrdma: remove
> unneeded variable
> 
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return status directly from function called.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
> change since v2: [PATCHv2] drivers:ocrdma:remove unneeded variable
>              v3: [PATCH v3 ocrdma-next] drivers: ocrdma: remove unneeded

This should be:
[PATCH for-next v3]: RDMA/ocrdma: remove unneeded...

> variable  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 735123d0e9ec..3bfbf4ec040d 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -1844,12 +1844,10 @@ int ocrdma_modify_srq(struct ib_srq *ibsrq,
> 
>  int ocrdma_query_srq(struct ib_srq *ibsrq, struct ib_srq_attr *srq_attr)  {
> -	int status;
>  	struct ocrdma_srq *srq;
> 
>  	srq = get_ocrdma_srq(ibsrq);
> -	status = ocrdma_mbx_query_srq(srq, srq_attr);
> -	return status;
> +	return ocrdma_mbx_query_srq(srq, srq_attr);
>  }
> 
>  int ocrdma_destroy_srq(struct ib_srq *ibsrq, struct ib_udata *udata) @@ -
> 1960,7 +1958,6 @@ static int ocrdma_build_inline_sges(struct ocrdma_qp
> *qp,  static int ocrdma_build_send(struct ocrdma_qp *qp, struct
> ocrdma_hdr_wqe *hdr,
>  			     const struct ib_send_wr *wr)
>  {
> -	int status;
>  	struct ocrdma_sge *sge;
>  	u32 wqe_size = sizeof(*hdr);
> 
> @@ -1972,8 +1969,7 @@ static int ocrdma_build_send(struct ocrdma_qp
> *qp, struct ocrdma_hdr_wqe *hdr,
>  		sge = (struct ocrdma_sge *)(hdr + 1);
>  	}
> 
> -	status = ocrdma_build_inline_sges(qp, hdr, sge, wr, wqe_size);
> -	return status;
> +	return ocrdma_build_inline_sges(qp, hdr, sge, wr, wqe_size);
>  }
> 
>  static int ocrdma_build_write(struct ocrdma_qp *qp, struct
> ocrdma_hdr_wqe *hdr,
> --
> 2.25.1