linux-kernel - Re: [RFC PATCH devicetree 01/10] irqchip/ls-extirq: rename "interrupt-map" OF property to "fsl,extirq-map"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnk7375x.fsf@kurt>
Date:   Tue, 14 Dec 2021 09:46:50 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     Marc Zyngier <maz@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        Biwen Li <biwen.li@....com>,
        Zhiqiang Hou <Zhiqiang.Hou@....com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [RFC PATCH devicetree 01/10] irqchip/ls-extirq: rename
 "interrupt-map" OF property to "fsl,extirq-map"

On Tue Dec 14 2021, Vladimir Oltean wrote:
> This OF property was supposed to be named "fsl,extirq-map" since the
> first patch submissions, but at Rob Herring's suggestion it was named
> "interrupt-map":
> https://lore.kernel.org/lkml/20190927161118.GA19333@bogus/

nit: The preferred form is https://lore.kernel.org/r/<message-id> 

[snip]

> diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c
> index 853b3972dbe7..b6ecc5e3472f 100644
> --- a/drivers/irqchip/irq-ls-extirq.c
> +++ b/drivers/irqchip/irq-ls-extirq.c
> @@ -101,9 +101,15 @@ ls_extirq_parse_map(struct ls_extirq_data *priv, struct device_node *node)
>  	u32 mapsize;
>  	int ret;
>  
> -	map = of_get_property(node, "interrupt-map", &mapsize);
> -	if (!map)
> -		return -ENOENT;
> +	map = of_get_property(node, "fsl,extirq-map", &mapsize);
> +	if (!map) {
> +		map = of_get_property(node, "interrupt-map", &mapsize);
> +		if (!map)
> +			return -ENOENT;
> +
> +		pr_warn("\"interrupt-map\" is a reserved OF property, and support for it will be removed. Please use \"fsl,extirq-map\" instead.\n");
> +	}

Looks reasonable. For instance, DSA does the same thing wrt "ports"
vs. "ethernet-ports".

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)