linux-kernel - Re: [PATCH 3/4] KVM: VMX: Fix stale docs for kvm-intel.emulate_invalid_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96c7c3c654481b650954ad12382ca28a6fc64a05.camel@redhat.com>
Date:   Tue, 14 Dec 2021 11:12:45 +0200
From:   Maxim Levitsky <mlevitsk@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+f1d2136db9c80d4733e8@...kaller.appspotmail.com
Subject: Re: [PATCH 3/4] KVM: VMX: Fix stale docs for
 kvm-intel.emulate_invalid_guest_state

On Tue, 2021-12-07 at 19:30 +0000, Sean Christopherson wrote:
> Update the documentation for kvm-intel's emulate_invalid_guest_state to
> rectify the description of KVM's default behavior, and to document that
> the behavior and thus parameter only applies to L1.
> 
> Fixes: a27685c33acc ("KVM: VMX: Emulate invalid guest state by default")
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9725c546a0d4..fc34332c8d9a 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2413,8 +2413,12 @@
>  			Default is 1 (enabled)
>  
>  	kvm-intel.emulate_invalid_guest_state=
> -			[KVM,Intel] Enable emulation of invalid guest states
> -			Default is 0 (disabled)
> +			[KVM,Intel] Disable emulation of invalid guest state.
> +			Ignored if kvm-intel.enable_unrestricted_guest=1, as
> +			guest state is never invalid for unrestricted guests.
> +			This param doesn't apply to nested guests (L2), as KVM
> +			never emulates invalid L2 guest state.
> +			Default is 1 (enabled)
>  
>  	kvm-intel.flexpriority=
>  			[KVM,Intel] Disable FlexPriority feature (TPR shadow).
Reviewed-by: Maxim Levitsky <mlevitsk@...hat.com>
Best regards,
	Maxim Levitsky