linux-kernel - Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ybh7KgtQt0/MFtyw@Air-de-Roger>
Date:   Tue, 14 Dec 2021 12:08:26 +0100
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Roger Pau Monné <roger.pau@...rix.com>
CC:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <boris.ostrovsky@...cle.com>, <jgross@...e.com>,
        <sstabellini@...nel.org>, <axboe@...nel.dk>,
        <xen-devel@...ts.xenproject.org>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable

On Tue, Dec 14, 2021 at 11:59:39AM +0100, Roger Pau Monné wrote:
> On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote:
> > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
> > open-coded arithmetic in allocator arguments.
> > 
> > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > consistency.
> > 
> > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Acked-by: Roger Pau Monné <roger.pau@...rix.com>

Oh, I see there's been further discussion on this to avoid relying
implicitly on the size of the bitmap being rounded to the size of an
unsigned long. I think a new version is expected then?

Thanks, Roger.