linux-kernel - Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <488aafc3-2fa9-198b-c448-d1ca7ef52f35@microchip.com>
Date:   Tue, 14 Dec 2021 11:16:19 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <quic_c_sbhanu@...cinc.com>, <dianders@...omium.org>,
        <michael@...le.cc>, <p.yadav@...com>, <miquel.raynal@...tlin.com>,
        <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC:     <stummala@...eaurora.org>, <vbadigan@...eaurora.org>,
        <quic_rampraka@...cinc.com>, <quic_pragalla@...cinc.com>,
        <sartgarg@...eaurora.org>
Subject: Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

On 12/14/21 12:16 PM, Shaik Sajida Bhanu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add support for winbond W25Q512NW-IM chip.
> 
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@...cinc.com>
> Reviewed-by: Doug Anderson <dianders@...omium.org>
> ---
> Changes since V1:
>         Added space before name of the flash part as suggested by Doug.
> 
> Changes since V2:
>         Updated chip name as w25q512nwm as suggested by Doug.
> ---
>  drivers/mtd/spi-nor/winbond.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 96573f6..42d5800 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },

This does not apply on current spi-nor/next. We've changed how the
flash_info flags are handled. We also require to dump the SPI NOR
sysfs entries under the comment section ---. I'll update the
documentation to add some guidelines on how new flash additions or
flash updates should be proposed. Sometime this week, or maybe
next.

Cheers,
ta