linux-kernel - Re: [PATCH v2] Instantiate key with user-provided decrypted data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec2ec0a9a7ba1adc6e54bbf7051a83ba90a39c0b.camel@linux.ibm.com>
Date:   Tue, 14 Dec 2021 07:37:30 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Yael Tiomkin <yaelt@...gle.com>, linux-integrity@...r.kernel.org
Cc:     jejb@...ux.ibm.com, jarkko@...nel.org, corbet@....net,
        dhowells@...hat.com, jmorris@...ei.org, serge@...lyn.com,
        keyrings@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-security-module <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v2] Instantiate key with user-provided decrypted data.

Hi Yael,

On Mon, 2021-12-13 at 14:20 -0500, Yael Tiomkin wrote:
> The encrypted.c class supports instantiation of encrypted keys with
> either an already-encrypted key material, or by generating new key
> material based on random numbers. To support encryption of
> user-provided decrypted data, this patch defines a new datablob
> format: [<format>] <master-key name> <decrypted data length>
> <decrypted data>.
> 
> Signed-off-by: Yael Tiomkin <yaelt@...gle.com>

Other than the comment below,
    Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>

Could you also provide an LTP test for defining, exporting, and loading
an encrypted key based on user provided key data?

thanks,

Mimi

> ---

> @@ -303,6 +306,16 @@ Load an encrypted key "evm" from saved blob::
>      82dbbc55be2a44616e4959430436dc4f2a7a9659aa60bb4652aeb2120f149ed197c564e0
>      24717c64 5972dcb82ab2dde83376d82b2e3c09ffc
>  
> +Instantiate an encrypted key "evm" using user-provided decrypted data::
> +
> +    $ keyctl add encrypted evm "new default user:kmk 32 `cat evm.blob`" @u
> +    794890253

The existing references to "evm.blob" refer to the encrypted key data. 
Here "evm.blob" is unencrypted data.  Perhaps name it something like
"evm.user-provided-data" data.

> +
> +    $ keyctl print 794890253
> +    default user:kmk 32 2375725ad57798846a9bbd240de8906f006e66c03af53b1b382d
> +    bbc55be2a44616e4959430436dc4f2a7a9659aa60bb4652aeb2120f149ed197c564e0247
> +    17c64 5972dcb82ab2dde83376d82b2e3c09ffc
> +