linux-kernel - Re: [PATCH] coccinelle: adjust the confidence of fen.cocci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2112141402240.2623@hadrien>
Date:   Tue, 14 Dec 2021 14:03:22 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Qing Wang <wangqing@...o.com>
cc:     Nicolas Palix <nicolas.palix@...g.fr>, cocci@...teme.lip6.fr,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccinelle: adjust the confidence of fen.cocci



On Tue, 14 Dec 2021, Qing Wang wrote:

> From: Wang Qing <wangqing@...o.com>
>
> We scan by coccinelle according to the confidence value, then check for
> potential problems. But the accuracy of this cocci is very low,
> the scan results are all wrong.

Can you give some examples of cases where the results are wrong?

thanks,
julia

>
> So, lower its confidence to low.
>
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  scripts/coccinelle/iterators/fen.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/iterators/fen.cocci b/scripts/coccinelle/iterators/fen.cocci
> index b69f966..7b71207
> --- a/scripts/coccinelle/iterators/fen.cocci
> +++ b/scripts/coccinelle/iterators/fen.cocci
> @@ -2,7 +2,7 @@
>  /// These iterators only exit normally when the loop cursor is NULL, so there
>  /// is no point to call of_node_put on the final value.
>  ///
> -// Confidence: High
> +// Confidence: Low
>  // Copyright: (C) 2010-2012 Nicolas Palix.
>  // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.
>  // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.
> --
> 2.7.4
>
>