linux-kernel - Re: [PATCH RESEND 3] libata: if T_LENGTH is zero, dma direction should be DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e512500-bcd2-2dff-0704-ccb52aad907b@opensource.wdc.com>
Date:   Tue, 14 Dec 2021 22:41:31 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     George Kennedy <george.kennedy@...cle.com>
Cc:     linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND 3] libata: if T_LENGTH is zero, dma direction
 should be DMA_NONE

On 2021/12/14 22:25, George Kennedy wrote:
> Avoid data corruption by rejecting pass-through commands where
> T_LENGTH is zero (No data is transferred) and the dma direction
> is not DMA_NONE.
> 
> Cc:<stable@...r.kernel.org>
> Reported-by: syzkaller<syzkaller@...glegroups.com>
> Signed-off-by: George Kennedy<george.kennedy@...cle.com>
> ---
>   drivers/ata/libata-scsi.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 1b84d55..d428392 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -2859,6 +2859,12 @@ static unsigned int ata_scsi_pass_thru(struct 
> ata_queued_cmd *qc)
>           goto invalid_fld;
>       }
> 
> +    /* if T_LENGTH is zero (No data is transferred), then dir should be 
> DMA_NONE */
> +    if ((cdb[2 + cdb_offset] & 3) == 0 && scmd->sc_data_direction != 
> DMA_NONE) {
> +        fp = 2 + cdb_offset;
> +        goto invalid_fld;
> +    }
> +
>       if (ata_is_ncq(tf->protocol) && (cdb[2 + cdb_offset] & 0x3) == 0)
>           tf->protocol = ATA_PROT_NCQ_NODATA;

Why didn't you change the code as I suggested ?

Since (cdb[2 + cdb_offset] & 3) == 0 is also used on the condition below, you
can clean this up like this:

	if (!(cdb[2 + cdb_offset] & 0x3)) {
		/*
		 * When T_LENGTH is zero (No data is transferred), dir should
		 * be DMA_NONE.
		 */
		if (scmd->sc_data_direction != DMA_NONE) {
			fp = 2 + cdb_offset;
			goto invalid_fld;
		}

		if (ata_is_ncq(tf->protocol))
			tf->protocol = ATA_PROT_NCQ_NODATA;
	}


-- 
Damien Le Moal
Western Digital Research