linux-kernel - Re: linux-next: Tree for Dec 13 (SND_AMD_ACP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15c3b6fe-b159-6cee-be67-11f2f2dd0d04@linux.intel.com>
Date:   Tue, 14 Dec 2021 07:51:21 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>, broonie@...nel.org,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     alsa-devel@...a-project.org,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for Dec 13 (SND_AMD_ACP_CONFIG)



> on i386 or x86_64:
> 
> when # CONFIG_ACPI is not set,
> so SND_SOC_ACPI is not set:
> 
> WARNING: unmet direct dependencies detected for SND_AMD_ACP_CONFIG
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_ACPI [=n]
>   Selected by [y]:
>   - SND_SOC_AMD_ACP_COMMON [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && X86 [=y] && PCI [=y]
> 
> 
> Full randconfig file is attached

It's probably triggered by my recent change to fix another problem.

d9b994cd7641 ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI

I didn't realize SND_AMD_ACP_CONFIG was selected by other configs.
Moving to a select seems to fix the issue reported by Randy, not sure if
it's the right thing to do though.


diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index bcfeb3fc2592..7a9e45094f37 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -98,7 +98,7 @@ config SND_SOC_AMD_YC_MACH

 config SND_AMD_ACP_CONFIG
        tristate "AMD ACP configuration selection"
-       depends on SND_SOC_ACPI
+       select SND_SOC_ACPI if ACPI
        help
         This option adds an auto detection to determine which ACP
         driver modules to use