linux-kernel - Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first parameter in orion_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Dec 2021 15:58:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Gregory Clement <gregory.clement@...tlin.com>
Subject: Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first
 parameter in orion_gpio_init()

On Tue, Dec 14, 2021 at 01:41:29PM +0000, Russell King (Oracle) wrote:
> On Tue, Dec 14, 2021 at 03:32:43PM +0200, Andy Shevchenko wrote:
> > The OF node pointer is always NULL, get rid of unused parameter in
> > orion_gpio_init(). As a side effect it will allow to switch GPIO
> > library to the fwnode API, as well as in case of resurrecting it here
> > it should be fwnode_handle anyways.
> 
> Please ensure the new code follows the existing style - especially in
> terms of wrapping. Some of us still use 80 columns as a general rule.
> Thanks.

Ah, okay, I will fix that for v2.

-- 
With Best Regards,
Andy Shevchenko