linux-kernel - Re: [RFC PATCH devicetree 01/10] irqchip/ls-extirq: rename "interrupt-map" OF property to "fsl,extirq-map"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqK2Shj6smam7HgNAmy3UG+vVQPkU3Q0OjyEHOEJB45n0A@mail.gmail.com>
Date:   Tue, 14 Dec 2021 09:07:33 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Marc Zyngier <maz@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Li Yang <leoyang.li@....com>, Biwen Li <biwen.li@....com>,
        Zhiqiang Hou <Zhiqiang.Hou@....com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [RFC PATCH devicetree 01/10] irqchip/ls-extirq: rename
 "interrupt-map" OF property to "fsl,extirq-map"

On Mon, Dec 13, 2021 at 7:38 PM Vladimir Oltean <vladimir.oltean@....com> wrote:
>
> This OF property was supposed to be named "fsl,extirq-map" since the
> first patch submissions, but at Rob Herring's suggestion it was named
> "interrupt-map":
> https://lore.kernel.org/lkml/20190927161118.GA19333@bogus/

I'm still not okay with a custom property. The fact that multiple
platforms need the same thing is an indication this should be common.
Other cases are being fixed by using 'interrupts', but that's going to
take some cleanups[1].

> At that time, the "interrupt-map" was ignored by the core for OF nodes
> that also had an "interrupt-controller" property, but that changed with
> commit 041284181226 ("of/irq: Allow matching of an interrupt-map local
> to an interrupt controller"), which made the consumer drivers of the
> ls-extirq break. To work around this breakage, the OF bindings for IRQs
> have introduced a table of "OF IRQ interrupt-map abusers".
> This can be seen in commit de4adddcbcc2 ("of/irq: Add a quirk for
> controllers with their own definition of interrupt-map").
>
> To stop being abusers, let's go back to the original form of these
> bindings, before Rob's review. Compatibility will be kept with the
> current abusive bindings for a few more kernel cycles, to give people
> some time to update. But to also give them an incentive, print a warning
> that the support for "interrupt-map" will be removed. This will be seen
> when running a new kernel with an old device tree.
>
> While the breakage was introduced relatively recently, the device tree
> changes are intended to backport stable kernels for quicker conversion
> to an acceptable set of bindings, and this driver will need to support
> the updated stable bindings.

Using 'interrupts' is not going to work backporting to stable, but I
don't think trying to switch this is worth it.

Rob

[1] https://lore.kernel.org/all/CAL_Jsq+jyqbhA1jpgZ+yTwWGvCMRu9VmgoDq8MDM9SMqJ-XSBw@mail.gmail.com/