linux-kernel - Re: [PATCH 13/43] kmsan: add KMSAN runtime core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Dec 2021 17:34:02 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Andy Lutomirski <luto@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...en8.de>,
        Christoph Hellwig <hch@....de>,
        Christoph Lameter <cl@...ux.com>,
        David Rientjes <rientjes@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Ilya Leoshkevich <iii@...ux.ibm.com>,
        Ingo Molnar <mingo@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Kees Cook <keescook@...omium.org>,
        Marco Elver <elver@...gle.com>,
        Matthew Wilcox <willy@...radead.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Pekka Enberg <penberg@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Vegard Nossum <vegard.nossum@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/43] kmsan: add KMSAN runtime core

On Tue, Dec 14, 2021 at 05:20:20PM +0100, Alexander Potapenko wrote:
> This patch adds the core parts of KMSAN runtime and associated files:
> 
>   - include/linux/kmsan-checks.h: user API to poison/unpoison/check
>     the kernel memory;
>   - include/linux/kmsan.h: declarations of KMSAN hooks to be referenced
>     outside of KMSAN runtime;
>   - lib/Kconfig.kmsan: CONFIG_KMSAN and related declarations;
>   - Makefile, mm/Makefile, mm/kmsan/Makefile: boilerplate Makefile code;
>   - mm/kmsan/annotations.c: non-inlineable implementation of KMSAN_INIT();
>   - mm/kmsan/core.c: core functions that operate with shadow and origin
>     memory and perform checks, utility functions;
>   - mm/kmsan/hooks.c: KMSAN hooks for kernel subsystems;
>   - mm/kmsan/init.c: KMSAN initialization routines;
>   - mm/kmsan/instrumentation.c: functions called by KMSAN instrumentation;
>   - mm/kmsan/kmsan.h: internal KMSAN declarations;
>   - mm/kmsan/shadow.c: routines that encapsulate metadata creation and
>     addressing;
>   - scripts/Makefile.kmsan: CFLAGS_KMSAN
>   - scripts/Makefile.lib: KMSAN_SANITIZE and KMSAN_ENABLE_CHECKS macros


That's an odd way to write a changelog, don't you think?

You need to describe what you are doing here and why you are doing it.
Not a list of file names, we can see that in the diffstat.

Also, you don't mention you are doing USB stuff here at all.  And why
are you doing it here?  That should be added in a later patch.

Break this up into smaller, logical, pieces that add the infrastructure
and build on it.  Don't just chop your patches up on a logical-file
boundry, as you are adding stuff in this patch that you do not need for
many more later on, which means it was not needed here.

thanks,

greg k-h