linux-kernel - Re: [PATCH v2 2/2] pinctrl: Propagate firmware node from a parent device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211214163818.GA2429@DESKTOP-LAINLKC.localdomain>
Date:   Tue, 14 Dec 2021 08:38:18 -0800
From:   Colin Foster <colin.foster@...advantage.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Marc Zyngier <maz@...nel.org>,
        Sam Shih <sam.shih@...iatek.com>,
        Zhiyong Tao <zhiyong.tao@...iatek.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Radim Pavlik <radim.pavlik@...-biometrics.com>,
        Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>,
        Douglas Anderson <dianders@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Herve Codina <herve.codina@...tlin.com>,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org, alsa-devel@...a-project.org,
        patches@...nsource.cirrus.com, linux-mediatek@...ts.infradead.org,
        linux-oxnas@...ups.io, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-msm@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Andreas Färber <afaerber@...e.de>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Sean Wang <sean.wang@...nel.org>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Support Opensource <support.opensource@...semi.com>,
        Baruch Siach <baruch@...s.co.il>,
        Neil Armstrong <narmstrong@...libre.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Andy Gross <agross@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Viresh Kumar <vireshk@...nel.org>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>, soc@...nel.org
Subject: Re: [PATCH v2 2/2] pinctrl: Propagate firmware node from a parent
 device

On Tue, Dec 14, 2021 at 02:58:55PM +0200, Andy Shevchenko wrote:
> When creating MFD platform devices the firmware node is left unset.
> This, in particular, prevents GPIO library to use it for different
> purposes. Propagate firmware node from the parent device and let
> GPIO library do the right thing.
> 

I came across the same thing this week. By populating the of_compatible
field of the mfd_cell, the child device will have the appropriate
firmware node populated. Unfortunately that currently means that I'll
have to put every device type in the MFD instead of in an of_match_table
in the child driver itself. Figuring that out is one of the next things
on my list.